Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for big Uint8Arrays in to_string() (that doesn't split buffers arbitrarily) #58

Merged
merged 1 commit into from
May 31, 2016
Merged

Adding support for big Uint8Arrays in to_string() (that doesn't split buffers arbitrarily) #58

merged 1 commit into from
May 31, 2016

Conversation

abenmrad
Copy link
Contributor

Follow up to issue #57.

@jedisct1
Copy link
Owner

Looks great!

UTF-8 is always quite painful to handle correctly :(

I'm away from keyboard now, but I'll test it and merge it as soon as I get back home.

Thanks, Batikh!

@abenmrad
Copy link
Contributor Author

If that could help you, I've already written some functions that could serve as a starting point for your tests. https://gist.github.com/BatikhSouri/d9d5f18041b3e890b43c4657e53ed22f

@jedisct1 jedisct1 merged commit 04f8ead into jedisct1:master May 31, 2016
@jedisct1
Copy link
Owner

Merged, thanks!

jedisct1 added a commit that referenced this pull request Jun 30, 2016
@jedisct1
Define toStringChunkSize
afeef7a 
This unbreaks the library after #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abenmrad @jedisct1